fix: flip IsSaving and IsLoading during all BB scripts serde functions #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
People can use MSU SerDe Emulators to save/load BB tables outside the regular save/load process of the game. These onSerialize and onDeserialize functions of the BB tables may contain or may affect logic that is dependent on knowing whether the game is being loaded or saved. This means that said logic should not trigger while the object is being serialized/deserialized. Therefore, we need to flip the IsSaving and IsLoading to true during ser/de of all BB tables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People can use MSU SerDe Emulators to save/load BB tables outside the regular save/load process of the game. These onSerialize and onDeserialize functions of the BB tables may contain or may affect logic that is dependent on knowing whether the game is being loaded or saved. This means that said logic should not trigger while the object is being serialized/deserialized. Therefore, we need to flip the IsSaving and IsLoading to true during ser/de of all BB tables.