Added automated tests with cypress for Service Requests form #9692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asirvadAbrahamVarghese
force-pushed
the
service-requests-form-automation-testing
branch
2 times, most recently
from
0ac63bc to
20b1181
Compare
Contributor
Author
asirvadAbrahamVarghese
force-pushed
the
service-requests-form-automation-testing
branch
4 times, most recently
from
b7b7b84 to
4cf95df
Compare
asirvadAbrahamVarghese
force-pushed
the
service-requests-form-automation-testing
branch
2 times, most recently
from
fc56d7a to
e38467e
Compare
asirvadAbrahamVarghese
changed the title
asirvadAbrahamVarghese
force-pushed
the
service-requests-form-automation-testing
branch
from
e38467e to
c4e6f6f
Compare
jrafanie
reviewed
Nov 5, 2025
asirvadAbrahamVarghese
force-pushed
the
service-requests-form-automation-testing
branch
from
c4e6f6f to
08fc52a
Compare
asirvadAbrahamVarghese
changed the title
asirvadAbrahamVarghese
force-pushed
the
service-requests-form-automation-testing
branch
from
08fc52a to
d14b54b
Compare
jrafanie
reviewed
Nov 12, 2025
jrafanie
reviewed
Nov 12, 2025
jrafanie
reviewed
Nov 12, 2025
| cy.menu(SERVICES_MENU_OPTION, REQUESTS_MENU_OPTION); | ||
| /* Reset */ | ||
| cy.getFormSelectFieldById({ selectId: 'selectedUser' }).select( | ||
| 'Test User 1' |
Member
There was a problem hiding this comment.
Is this a user we created or a hardcoded value? The name of the user is curious. If it's coming from the factory, the number is not required to be 1:
spec/factories/user.rb: sequence(:name) { |s| "Test User #{s}" }
Maybe a more generic grep like select would grab the first "Test User" from the select.
Contributor
Author
There was a problem hiding this comment.
Yeah this user is created by factory
Changed the logic to pick any option by value except "all", so that if the username changes later from “Test User” to something else, the test won’t fail
jrafanie
reviewed
Nov 12, 2025
| }).click(); | ||
| cy.gtlGetRows([0]).then((data) => { | ||
| expect(data.length).to.equal(3); | ||
| }); |
Member
There was a problem hiding this comment.
Does it make sense to make this a function? It feels like the different filter sections are doing similar things and verifying their results.
Contributor
Author
There was a problem hiding this comment.
Yeah that makes sense
asirvadAbrahamVarghese
force-pushed
the
service-requests-form-automation-testing
branch
2 times, most recently
from
dae33e5 to
296a7a8
Compare
Fryguy
reviewed
Nov 18, 2025
asirvadAbrahamVarghese
force-pushed
the
service-requests-form-automation-testing
branch
2 times, most recently
from
f3a3d62 to
77e1133
Compare
asirvadAbrahamVarghese
force-pushed
the
service-requests-form-automation-testing
branch
from
77e1133 to
260fb76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CP4AIOPS-18932:
Add test to cover:
- Validate form elements
- Validate reset and apply functionalities
@miq-bot add-label cypress
@miq-bot add-label test
@miq-bot assign @jrafanie