[WIP] Replace top level ems factories dummy provider #23648
+24
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we have what looks like a generic ems factory (e.g. ems_infra) but it really points to a concrete provider (ems_vmware) which has implications for supported features that are implicit rather than explicit in the specs that use them.
agrare
force-pushed
the
replace_top_level_ems_factories_dummy_provider
branch
from
29ca30a to
89954de
Compare
Member
Author
|
@miq-bot cross-repo-tests ManageIQ/manageiq-providers-dummy_provider#77 |
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Nov 4, 2025
From Pull Request: ManageIQ/manageiq#23648
Fryguy
reviewed
Nov 4, 2025
agrare
force-pushed
the
replace_top_level_ems_factories_dummy_provider
branch
from
89954de to
f712362
Compare
Member
Author
|
Down to 5 failures: |
agrare
force-pushed
the
replace_top_level_ems_factories_dummy_provider
branch
from
f712362 to
32224d4
Compare
agrare
force-pushed
the
replace_top_level_ems_factories_dummy_provider
branch
from
32224d4 to
603da04
Compare
agrare
commented
Nov 4, 2025
| let(:ems_other) { FactoryBot.create(:ems_container) } | ||
|
|
||
| it "calls destroy for objects with ruby callbacks" do | ||
| expect_any_instance_of(ems.class).to receive(:destroy) |
Member
Author
There was a problem hiding this comment.
NOTE I don't know why this was failing for the DummyProvider::ContainerManager, but the rest of the tests check expect().to be_deleted not any_instance_of(). I don't see anything deep_delete specific in Kubernetes or Openshift so not sure why it is different.
I still don't like changing this test though so some investigation needed.
Member
There was a problem hiding this comment.
I wonder if this is because real providers have child providers (ems) and the Dummy does not?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.