Utils list fix #22
Open
Utils list fix #22
+20
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
victoria-cherkas
left a comment
victoria-cherkas
left a comment
There was a problem hiding this comment.
While we are looking at this, I think it would be best practice to test that the list_all_values is called with expected values, in test_cli.py . You could mock list_all_values and just assert the call args based on the cli inputs.
| def list_metadata( | ||
| show: Annotated[str, typer.Option(help='The keys to print, eg. "step,number,param"')] = "", | ||
| filter_values: Annotated[str, typer.Option("--filter", help='The metadata to filter results by, eg "date=20240624,time=0600".')] = "" | ||
| show: Annotated[str, typer.Argument(help='The keys to print, eg. "step,number,param"')] = "", |
Collaborator
There was a problem hiding this comment.
Does typer.Argument not mean that we need to provide this? Or is it still optional?
Contributor
Author
There was a problem hiding this comment.
According to my research no, also the test is green. Thus, I think it is fine.
However to mock list_all_values sounds good.
Collaborator
There was a problem hiding this comment.
True true thanks for pointing to that test.
Yes i think that would be really nice, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix command fdb-utils list --filter.
Command typer.Options not compatible with typer.Options --filter. Thus, replace with typer.Arguments which is still optional.
Plus add new shortcut -f for --filter.