Skip to content

fix: criticals #5777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 18, 2025
Merged

fix: criticals #5777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cdad231
fix: jump and minijump criticals working in cobwebs
cattyngmd Oct 18, 2025
2b1bbfd
fix: jump criticals failing to attack
cattyngmd Oct 18, 2025
3b13b2c
fix: wrong return value
cattyngmd Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/main/java/meteordevelopment/meteorclient/systems/modules/combat/Criticals.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import meteordevelopment.meteorclient.systems.modules.Categories;
import meteordevelopment.meteorclient.systems.modules.Module;
import meteordevelopment.meteorclient.systems.modules.Modules;
import meteordevelopment.meteorclient.utils.entity.EntityUtils;
import meteordevelopment.orbit.EventHandler;
import net.minecraft.entity.Entity;
import net.minecraft.entity.LivingEntity;
Expand Down Expand Up @@ -151,14 +152,17 @@ private void onTick(TickEvent.Pre event) {
}

if (sendTimer <= 0) {
sendPackets = false;

if (attackPacket == null || swingPacket == null) return;
if (attackPacket == null || swingPacket == null) {
sendPackets = false;
return;
}
mc.getNetworkHandler().sendPacket(attackPacket);
mc.getNetworkHandler().sendPacket(swingPacket);

attackPacket = null;
swingPacket = null;

sendPackets = false;
} else {
sendTimer--;
}
Expand All @@ -177,6 +181,9 @@ private void sendPacket(double height) {
}

private boolean skipCrit() {
if (EntityUtils.isInCobweb(mc.player) && (mode.get() == Mode.Jump || mode.get() == Mode.MiniJump))
return true;

return !mc.player.isOnGround() || mc.player.isSubmergedInWater() || mc.player.isInLava() || mc.player.isClimbing();
}

Expand Down
4 changes: 4 additions & 0 deletions src/main/java/meteordevelopment/meteorclient/utils/entity/EntityUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,10 @@ public static boolean isAboveWater(Entity entity) {
return false;
}

public static boolean isInCobweb(Entity entity) {
return mc.world.getStatesInBoxIfLoaded(entity.getBoundingBox()).anyMatch(state -> state.isOf(Blocks.COBWEB));
}

public static boolean isInRenderDistance(Entity entity) {
if (entity == null) return false;
return isInRenderDistance(entity.getX(), entity.getZ());
Expand Down