Fix GenericSetting and Vector3dSetting not calling onChanged #5780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
crosby-moe
suggested changes
Oct 19, 2025
Collaborator
crosby-moe
left a comment
crosby-moe
left a comment
There was a problem hiding this comment.
the changes for Vector3dSetting are correct, however the changes to GenericSetting would have resulted in the onChanged consumer being called without any changes actually made to the setting
fixing this would have required some refactoring, so i have taken the liberty of doing it all myself in #5787
Collaborator
|
closed in favour of #5787 |
Collaborator
|
|
mankool0
force-pushed
the
fix-generic-setting-onchanged
branch
from
cc6cca6 to
830656a
Compare
Contributor
Author
|
I've removed my |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
screen.onClosed()callback ingenericW()to callsetting.onChanged()addVectorComponent()to callsetting.onChanged()ESPBlockDataScreen.onChanged()to always callsetting.onChanged(), not just on first editHow Has This Been Tested?
Logging to verify
onChanged()callbacks fire correctly.Checklist: