Replace the coordinate check using a regex with numerical analysis #5911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added handling for PlayerRespawnS2CPacket in onPacketReceive to automatically deactivate the Freecam module when the player changes dimension (e.g. entering the nether). This prevents a hard freeze caused by conflicts between Freecam logic and world reinitialization during teleportation.
The coordinate detection method has been rewritten: instead of using a regular expression, it now checks for two consecutive numeric values in the message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
The coordinate detection method has been rewritten: instead of using a regular expression, it now checks for two consecutive numeric values in the message.
Related issues
Easier protection for those fools who write their coordinates in the global chat
Videos or screenshots of the changes if applicable.
Checklist: