isVoiceAvailable() should return true if there are activities available to handle a voice search #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
1 similar comment
|
+1 |
Owner
|
Sorry for the delay, I've been full of shit for the last few months. In the next days I will check all the PRs and give you an answer. |
|
@jkreiser +1 for this PR, it really fixes the issue with voice icon not being visible |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless I'm missing something, shouldn't isVoiceAvailable() return true if the list of activities that can handle RecognizerIntent.ACTION_RECOGNIZE_SPEECH is greater than 0? Is there a reason why it should return true if the list has 0 items?