Skip to content

WIP - Amber writer #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
janash wants to merge 8 commits into
base: master
Choose a base branch
from
Open

WIP - Amber writer #39

janash wants to merge 8 commits into from

Conversation

@janash
Copy link
Member

@janash janash commented Sep 7, 2018

This pull request will update the _compatibility_check function for amber.

The following actions must be performed for successful conversion.

  • Use amber metadata to check if functional form is compatible
  • Remove incompatible terms using remove_terms function in datalayer
  • Perform functional form conversion
  • Re-add compatible functional forms
  • Create tests to test conversions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@janash