Fix Winapp3, Winapp2 + Non-CCleaner: %CommonAppData% -> %ProgramData%
#966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Remake of #954 (Accidentally deleted head repository) and now based on the latest Winapp2 changes by MoscaDotTo |
Collaborator
|
It seems that you accidentally replaced |
Fix typo of path
Fix typo of path
Fix typo of path
Author
Wow, thanks! I've added the fix to the PR (i made sure to rebase it to @MoscaDotTo's new versions and re-apply the patch from scratch) |
MoscaDotTo
added a commit
that referenced
this pull request
Oct 8, 2025
move away from CCleaner environment variables change *.* -> * (standard notation in winapp2.ini for a few years) captures work done in #966
Collaborator
|
I think this pull request can now be closed, as @MoscaDotTo has corrected all variables in the source files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The environment variable
%CommonAppData%was apparently replaced by the variable%ProgramData%after the big overhaul.Originally posted by @APMichael in #948 (comment)
%CommonAppData%no longer exists in modern Windows builds. Let's not leave out Winapp3, Winapp2 (minimally) and Non-CCleaner variants, they haven't been working properly as a result.@MoscaDotTo @APMichael