Skip to content

Conversation

@madbaron
Copy link

@madbaron madbaron commented Sep 5, 2025

This PR brings in a few quality of life improvements

BEGINRELEASENOTES

  • Updated various filter processors to output subset collections for better memory performance
  • Fixed bug in hit-to-simhit relation propagation in filter processors
  • Added argument to filter tracker hits based on 3D distance from helix
    ENDRELEASENOTES

@madbaron madbaron requested a review from Copilot September 5, 2025 20:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR brings quality of life improvements to filter processors by implementing subset collections for better memory performance, fixing hit-to-simhit relation propagation bugs, and adding 3D distance-based filtering capabilities.

  • Refactored filter processors to use subset collections instead of creating new hit objects, reducing memory overhead
  • Fixed bug in hit-to-simhit relation propagation by properly using LCRelationNavigator
  • Added argument to filter tracker hits based on 3D distance from helix in addition to angular distance

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
source/Utils/src/FilterTracks.cc Added debug logging for calorimeter state filtering
source/Utils/src/FilterTimeHits.cc Refactored to use subset collections and fixed relation handling with LCRelationNavigator
source/Utils/src/FilterConeHits.cc Major refactor using subset collections, added 3D distance filtering, and improved relation handling
source/Utils/src/FilterClusters.cc Enhanced with subset collections, improved theta binning logic, and added diagnostic histograms
source/Utils/include/FilterConeHits.h Added member variable for 3D distance cut parameter
source/Utils/include/FilterClusters.h Added histogram members and reorganized class structure

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@madbaron madbaron merged commit 13ab4fd into MuonColliderSoft:master Sep 5, 2025
4 checks passed
@madbaron madbaron deleted the subset_collections branch September 5, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant