Skip to content

[app] Adds ledger hash & warning when signing #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2025
Merged

[app] Adds ledger hash & warning when signing #44

merged 1 commit into from
Oct 22, 2025

Conversation

@manolisliolios
Copy link
Collaborator

@manolisliolios manolisliolios commented Oct 21, 2025

  1. Adds the ledger hash for a transaction on its preview.
  2. Adds a warning that the user must consult the wallet preview for verifying what they are signing.

rjs-mysten
rjs-mysten approved these changes Oct 21, 2025
View reviewed changes
Copy link

@rjs-mysten rjs-mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the good old lgtm

@manolisliolios manolisliolios merged commit 874776c into main Oct 22, 2025
4 checks passed
@manolisliolios manolisliolios deleted the ml/enable-ledger-hash branch October 22, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjs-mysten rjs-mysten rjs-mysten approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@manolisliolios @rjs-mysten