Skip to content

[dkg-cli] add generate-keys and init command #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 5, 2025
Merged

[dkg-cli] add generate-keys and init command #354

merged 4 commits into from
Nov 5, 2025

Conversation

@joyqvq
Copy link
Collaborator

@joyqvq joyqvq commented Oct 20, 2025 •
edited
Loading

Description

Test plan

How did you test the new or updated feature?

@joyqvq joyqvq force-pushed the joy/dkg-init-cli branch 2 times, most recently from e1f0fce to f3217f7 Compare October 21, 2025 02:51
@joyqvq joyqvq changed the title Joy/dkg init cli [dkg-cli] add generate-keys and init command Oct 21, 2025
@joyqvq joyqvq marked this pull request as ready for review October 21, 2025 21:23
@joyqvq joyqvq force-pushed the joy/dkg-init-cli branch 5 times, most recently from fade3fd to 679664d Compare October 22, 2025 20:58
benr-ml
benr-ml reviewed Oct 23, 2025
View reviewed changes
@joyqvq joyqvq force-pushed the joy/dkg-init-cli branch 2 times, most recently from 642127b to 9fc3ec1 Compare October 24, 2025 16:14
@joyqvq joyqvq requested a review from benr-ml October 24, 2025 16:17
joyqvq
joyqvq commented Oct 30, 2025
View reviewed changes
@joyqvq joyqvq force-pushed the joy/dkg-init-cli branch 2 times, most recently from 246025c to d9174d5 Compare October 30, 2025 17:52
@joyqvq joyqvq changed the base branch from main to joy/seal-committee-only October 30, 2025 17:52
@joyqvq joyqvq mentioned this pull request Oct 30, 2025
Merged
@joyqvq
Copy link
Collaborator Author

joyqvq commented Oct 30, 2025

cc @benr-ml plz review this pr first - #376

i split off to a smaller for grpc helper things so its easier to review + work on key-server crate

Base automatically changed from joy/seal-committee-only to main October 31, 2025 16:12
@joyqvq joyqvq force-pushed the joy/dkg-init-cli branch 3 times, most recently from 14c5fba to 5182fcc Compare October 31, 2025 17:49
benr-ml
benr-ml reviewed Nov 2, 2025
View reviewed changes
benr-ml
benr-ml reviewed Nov 4, 2025
View reviewed changes
benr-ml
benr-ml approved these changes Nov 5, 2025
View reviewed changes
@joyqvq joyqvq enabled auto-merge (squash) November 5, 2025 18:16
@joyqvq joyqvq merged commit c9d66a4 into main Nov 5, 2025
8 checks passed
@joyqvq joyqvq deleted the joy/dkg-init-cli branch November 5, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benr-ml benr-ml benr-ml approved these changes

@abhinavg6 abhinavg6 Awaiting requested review from abhinavg6 abhinavg6 is a code owner

@jonas-lj jonas-lj Awaiting requested review from jonas-lj jonas-lj is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joyqvq @benr-ml