-
Notifications
You must be signed in to change notification settings - Fork 92
feat: slicing strategy for blob store operations #2637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Warning: This PR modifies the Walrus CLI. Please consider the following:
|
0661a4c to
e8e7a83
Compare
e8e7a83 to
4764290
Compare
4764290 to
085b1c2
Compare
|
Hi 👋 I want to ask about two things:
|
|
Hey Michal!
Yes, at this time the design is geared towards simplicity in that manner. It's not crazy to think that this could be extended to include an indrection through another "index" or "manifest" blob, or simply an object on-chain, although those do have various tradeoffs to consider.
I'm also working on a concatenated streaming api in the aggregator. The way I'm looking at it, the design of these large-blob features really depends on how they will eventually be consumed. I think as a next step after the basic blob-level granularity it makes sense to try quilt patches as chunks. That could be a good idea, but it will take some careful measurement to understand the trade-offs between storage efficiency and latency to first-read, etc. |
|
This PR is stale because it has been open 14 days with no activity. It will be closed in 7 days unless you remove the |
|
Keep alive for now. |
|
This PR is stale because it has been open 14 days with no activity. It will be closed in 7 days unless you remove the |
Description
Enable automatic file slicing during
walrus store.Test plan
Manual testing, CI Pipeline.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that
a user might notice and any actions they must take to implement updates. (Add release notes after the colon for each item)
--slice-sizeargument to thewalrus storecommand that allows for slicing very large files into smaller chunks. The workflow here is to utilize this, then upon fetching all of the stored blobs (in order), concatenating them back together. This is a bit of an advanced procedure for folks with more complex requirements. Note that this is a building block that future features can take advantage of.