Added the chimere model, and fixed a minor bug #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the chimere model adapter that i also pull request'ed to monetio.
Fixed a minor bug in border definition for spatial_overlay graphs.
Might need to confirm that it was non intended behaviour but when making custom polygons for data filtering and creating a spatial_overlay graph an error occured where a float was expected but an xarray.dataarray (or dataset can't recall now) was provided.
You can check that in other if-statements around the fix the values are set to floats (like when the borders are provided for CONUS or EPA regions)
I just changed the order of the operations so it actually provides the minlat, minlon, ... for the vmodel data.