Skip to content

DS-1710 More efficient DoS database Reader usage #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

DS-1710 More efficient DoS database Reader usage #970

wants to merge 10 commits into from

Conversation

@mabe13
Copy link
Collaborator

@mabe13 mabe13 commented Dec 19, 2023 •
edited by github-actions bot
Loading

Task Branch Pull Request

https://nhsd-jira.digital.nhs.uk/browse/DS-1710

Description of Changes

Please include a summary of the change

Type of change

Delete not appropriate

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change which improves the structure of the code)

Development Checklist

  • I have performed a self-review of my own code
  • Tests have added that prove my fix is effective or that my feature works (Integration tests)
  • I have updated Dependabot to include my changes (if applicable)

Code Reviewer Checklist

  • I can confirm the changes have been tested or approved by a tester

@mabe13 mabe13 force-pushed the task/DS-1710_Db_reader_usage_refactoring branch from 35c5c57 to 297e4c0 Compare December 19, 2023 16:51
@mabe13 mabe13 force-pushed the task/DS-1710_Db_reader_usage_refactoring branch 2 times, most recently from f9db9c2 to a370893 Compare December 27, 2023 16:33
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 28, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

66.3% Coverage on New Code (required ≥ 95%)

See analysis details on SonarCloud

@mabe13 mabe13 force-pushed the task/DS-1710_Db_reader_usage_refactoring branch from a5d0899 to 6e25140 Compare January 9, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mabe13