Fix deconvolution parameters #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bounds on the
sigmaandhwhmdeconvolution parameters. The maximum has to be scaled by the max of the data as well as the length of the data to cater for different scenarios (normalized vs. unnormalized spectra, length of chosen ranges.This should fix the spurious very wide, flat peaks that were sometimes found when the peak is very small.
Other fixes include adding the matplotlib
rollparameter to 3D plots to allow for greater flexibility in customising plots, as well as fixing code relying on the new acqtime/acqtime_array structure.@torogi94 please test the deconvolution with Erik's data.