Update UnitarySystem set point control #10571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mitchute merged 14 commits into develop from 10570-UnitarySystem-VS-coil-SP-not-working

Oct 31, 2025

Contributor

rraustad commented Jun 18, 2024

Pull request overview

Fixes AirloopHVAC:UnitarySystem set point control does not turn on cooling coil #10570
Testing showed that set point controls in UnitarySystem did not turn on the cooling coil and other coils did not respond as anticipated.

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Reviewer

This will not be exhaustively relevant to every PR.


          Update UnitarySystem set point control

6f83135

rraustad added the Defect label

Contributor Author

rraustad commented Jun 18, 2024 •

edited

Loading

This branch shows all coils now turn on and set point is maintained except for when the AvailabilityManger is turning off the system at night for a few hours and on a weekend. I'm not exactly sure yet where the change in air flow from cooling to heating is coming from.

Component Sizing Information, Fan:SystemModel, SUPPLY FAN 1, User-Specified Design Maximum Air Flow Rate [m3/s], 1.00000
Component Sizing Information, AirLoopHVAC:UnitarySystem, WATER-TO-AIR HEAT PUMP UNIT 1, User-Specified Supply Air Flow Rate [m3/s], 1.00000
Component Sizing Information, AirLoopHVAC:UnitarySystem, WATER-TO-AIR HEAT PUMP UNIT 1, User-Specified Heating Supply Air Flow Rate [m3/s], 1.00000
Component Sizing Information, AirLoopHVAC:UnitarySystem, WATER-TO-AIR HEAT PUMP UNIT 1, User-Specified Cooling Supply Air Flow Rate [m3/s], 1.00000
Component Sizing Information, AirLoopHVAC:UnitarySystem, WATER-TO-AIR HEAT PUMP UNIT 1, User-Specified No Load Supply Air Flow Rate [m3/s], 0.00000
Component Sizing Information, COIL:COOLING:WATERTOAIRHEATPUMP:VARIABLESPEEDEQUATIONFIT, SYS 1 HEAT PUMP COOLING MODE, Design Size Rated Air Flow Rate [m3/s], 1.00000
Component Sizing Information, COIL:COOLING:WATERTOAIRHEATPUMP:VARIABLESPEEDEQUATIONFIT, SYS 1 HEAT PUMP COOLING MODE, User-Specified Rated Air Flow Rate [m3/s], 1.00000

rraustad marked this pull request as draft

June 18, 2024 19:00

nrel-bot-3 commented Jul 17, 2024

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

4 similar comments

nrel-bot-2c commented Aug 14, 2024

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

nrel-bot commented Sep 11, 2024

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

nrel-bot-2 commented Oct 9, 2024

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

nrel-bot-2c commented Nov 6, 2024

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

nrel-bot-2 commented Nov 22, 2024

@rraustad it has been 16 days since this pull request was last updated.

nrel-bot-2c commented Nov 29, 2024

@rraustad it has been 7 days since this pull request was last updated.

2 similar comments

nrel-bot-2c commented Dec 6, 2024

@rraustad it has been 7 days since this pull request was last updated.

nrel-bot-2c commented Dec 13, 2024

@rraustad it has been 7 days since this pull request was last updated.

nrel-bot-2 commented Dec 21, 2024

@rraustad it has been 8 days since this pull request was last updated.

nrel-bot-2 commented Dec 28, 2024

@rraustad it has been 7 days since this pull request was last updated.

9 similar comments

nrel-bot-2 commented Jan 4, 2025

@rraustad it has been 7 days since this pull request was last updated.

nrel-bot-2 commented Jan 11, 2025

@rraustad it has been 7 days since this pull request was last updated.

nrel-bot-2 commented Jan 18, 2025

@rraustad it has been 7 days since this pull request was last updated.

nrel-bot-2 commented Jan 25, 2025

@rraustad it has been 7 days since this pull request was last updated.

nrel-bot-2c commented Feb 1, 2025

@rraustad it has been 7 days since this pull request was last updated.

nrel-bot-2 commented Feb 8, 2025

@rraustad it has been 7 days since this pull request was last updated.

nrel-bot-2 commented Feb 15, 2025

@rraustad it has been 7 days since this pull request was last updated.

nrel-bot-2c commented Feb 22, 2025

@rraustad it has been 7 days since this pull request was last updated.

nrel-bot-2c commented Mar 1, 2025

@rraustad it has been 7 days since this pull request was last updated.

nrel-bot-2c commented Mar 9, 2025

@rraustad it has been 8 days since this pull request was last updated.

nrel-bot-2c commented Mar 16, 2025

@rraustad it has been 7 days since this pull request was last updated.

4 similar comments

nrel-bot-2c commented Mar 23, 2025

@rraustad it has been 7 days since this pull request was last updated.

nrel-bot-2c commented Mar 30, 2025

@rraustad it has been 7 days since this pull request was last updated.

nrel-bot-2c commented Apr 6, 2025

@rraustad it has been 7 days since this pull request was last updated.

nrel-bot-2c commented Apr 13, 2025

@rraustad it has been 7 days since this pull request was last updated.

github-actions bot commented Oct 23, 2025

⚠️ Regressions detected on ubuntu-24.04 for commit `7315087`

Regression Summary

ERR: 2
ESO Big Diffs: 1
Table Big Diffs: 3

github-actions bot commented Oct 23, 2025

⚠️ Regressions detected on macos-14 for commit `7315087`

Regression Summary

ERR: 2
ESO Big Diffs: 1
Table Big Diffs: 3


          Removing these doesn't change answer. LastMode should hold last opera…

3e23136

…tion.

github-actions bot commented Oct 24, 2025

⚠️ Regressions detected on macos-14 for commit `9346444`

Regression Summary

ERR: 2
ESO Big Diffs: 1
Table Big Diffs: 3

github-actions bot commented Oct 24, 2025

⚠️ Regressions detected on ubuntu-24.04 for commit `9346444`

Regression Summary

ERR: 2
ESO Big Diffs: 1
Table Big Diffs: 3

rraustad marked this pull request as draft

October 24, 2025 02:07

rraustad added 4 commits

October 23, 2025 22:27


          Revert as much code and still get defect file to run

fd52405


          Merge branch 'develop' of https://github.com/NREL/EnergyPlus into 105…

295e013

…70-UnitarySystem-VS-coil-SP-not-working


          Back out everything to start over

281ef2d


          Bare minimum to get UnitarySystem to turn on

fd4d74b

rraustad marked this pull request as ready for review

October 24, 2025 03:27

Contributor Author

rraustad commented Oct 24, 2025 •

edited

Loading

@mitchute I backed out all changes and started over. These are the minimum changes that get the system to at least turn on. I think I would rather have the system at least operate, albeit with some control issues, than not turn on at all. I will post a new issue to address the remaining issue which is out of scope and a user input control problem to either use the previous on air flow or off air flow (i.e. the m_AirFlowControl flag). This defect file is set point controlled which should honor this control choice.

//  set air flow control mode:
//  m_AirFlowControl = UseCompFlow::On means operate at last cooling or heating air flow requested when compressor is off
//  m_AirFlowControl = UseCompFlow::Off means operate at no load air flow value specified by user
//  AirFlowControl only valid if fan opmode = ContFanCycComp
if (this->m_MaxNoCoolHeatAirVolFlow == 0.0) {
    this->m_AirFlowControl = UseCompFlow::On;
} else {
    this->m_AirFlowControl = UseCompFlow::Off;
}

Contributor Author

rraustad commented Oct 24, 2025 •

edited

Loading

Results after these changes. Top right figure shows set point control is working.

{C2C9210C-9C0E-4FFD-81D9-F22759D29F14}

develop branch:

{74AC992F-49D8-45AE-A644-EAACEA0D85C3}

rraustad commented

View reviewed changes

src/EnergyPlus/UnitarySystem.cc Outdated

+                      // set variables used in fan call inside function calcPassiveSystem
+                      state.dataUnitarySystems->m_massFlow1 = state.dataLoopNodes->Node(this->AirInNode).MassFlowRate;
+                      state.dataUnitarySystems->m_runTimeFraction1 = (state.dataUnitarySystems->m_massFlow1 > 0.0) ? 1.0 : 0.0; // constant fan mode is required

Contributor Author

rraustad Oct 24, 2025 •

edited

Loading

If either of these changes are removed, the system air flow goes to 0 and there is no control to set point temperature. I'm not quite sure the initialization of LastMode should be done in getInput but I am warming up to it since the mode needs to start somewhere. If the mode is not set from 0 to cooling or heating mode the fan does not turn on. So this change seems OK. And if the fan operating parameters are not set, for set point controlled systems, then the fan won't turn on. So this also seems OK.

Collaborator

mitchute Oct 27, 2025

@rraustad do you think this is captured in our tests already? Given your description, it seems like we should have some sort of test to ensure this continues to function.

Contributor Author

rraustad Oct 27, 2025

This was hard to track down. The defect file has Fan:SystemModel in a modified example file (UnitarySystem_VSHeatPumpWaterToAirEquationFit). Unit tests have legacy fans. One unit test has Fan:System models but doesn't test controls. The Fan:SystemModel needs to set these 2 variables for the fan call in calcPassiveSystem. This may have started with the fan refactor or a change to UnitarySystem that did not notice this corner case. I'm trying to figure out a good place for a unit test.

Contributor Author

rraustad Oct 27, 2025

First 2 unit tests passed fine without any changes. Then figured out that it was the coil type and the fan type that caused this issue and a specific unit test was added. That unit test fails without these changes. This coil type was calling calcPassiveSystem when it did not need to. Those lines were deleted. Since that function is no longer called the new lines to set the fan parameters were also not needed.

github-actions bot commented Oct 24, 2025

⚠️ Regressions detected on ubuntu-24.04 for commit `3af7ce5`

Regression Summary

IDF: 5

NREL deleted a comment from github-actions bot

rraustad added 2 commits

October 27, 2025 17:53


          Add unit test, revert call to calcPassiveSystem in SP control function

4fc2af5


          Merge branch 'develop' of https://github.com/NREL/EnergyPlus into 105…

6898bd6

…70-UnitarySystem-VS-coil-SP-not-working

github-actions bot commented Oct 27, 2025

⚠️ Regressions detected on ubuntu-24.04 for commit `5aae7c6`

Regression Summary

ERR: 1

github-actions bot commented Oct 27, 2025

⚠️ Regressions detected on macos-14 for commit `5aae7c6`

Regression Summary

ERR: 1

dareumnam added 2 commits

October 29, 2025 15:58


          clang format

d44fccb


          Merge branch 'develop' of https://github.com/NREL/EnergyPlus into 105…

1607d66

…70-UnitarySystem-VS-coil-SP-not-working

github-actions bot commented Oct 29, 2025

⚠️ Regressions detected on ubuntu-24.04 for commit `cdff51b`

Regression Summary

ERR: 1

github-actions bot commented Oct 29, 2025

⚠️ Regressions detected on macos-14 for commit `cdff51b`

Regression Summary

ERR: 1


          Merge branch 'develop' into 10570-UnitarySystem-VS-coil-SP-not-working

92357b7

github-actions bot commented Oct 31, 2025

⚠️ Regressions detected on ubuntu-24.04 for commit `ae81c27`

Regression Summary

ERR: 1

github-actions bot commented Oct 31, 2025

⚠️ Regressions detected on macos-14 for commit `ae81c27`

Regression Summary

ERR: 1

mitchute approved these changes

View reviewed changes

Collaborator

mitchute left a comment

Looking good here. Merging.

mitchute merged commit 61f54b2 into develop

11 checks passed

mitchute deleted the 10570-UnitarySystem-VS-coil-SP-not-working branch

October 31, 2025 23:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Defect