Skip to content

Conversation

@Jorjeous
Copy link
Member

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Obsolete Attribute

Collection: [Tools, ASR]

Changelog

  • Add specific line by line info of high level changes in this PR.

app.run

Usage

  • You can potentially add a usage example below
python NeMo/tools/speech_data_explorer/data_explorer.py manifest.jsonl

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • [+] Did you write any new necessary tests? [not needed]
  • [+] Did you add or update any necessary documentation? [not needed]
  • [+] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • [+] Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

Signed-off-by: George Zelenfroind <[email protected]>
@Jorjeous Jorjeous requested a review from nithinraok November 21, 2025 13:12
@nithinraok nithinraok added ASR r2.6.0 Cherry-pick label for the r2.6.0 release branch Run CICD labels Nov 21, 2025
@github-actions github-actions bot removed the Run CICD label Nov 21, 2025
@github-actions
Copy link
Contributor

[🤖]: Hi @Jorjeous 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

@Jorjeous Jorjeous merged commit 1b4d6dc into main Nov 21, 2025
85 of 87 checks passed
@Jorjeous Jorjeous deleted the data_explorere_fix_stale branch November 21, 2025 15:21
@Jorjeous Jorjeous restored the data_explorere_fix_stale branch November 21, 2025 15:21
chtruong814 pushed a commit that referenced this pull request Nov 21, 2025
* update run_server to run

Signed-off-by: George Zelenfroind <[email protected]>

* Apply isort and black reformatting

Signed-off-by: Jorjeous <[email protected]>

---------

Signed-off-by: George Zelenfroind <[email protected]>
Signed-off-by: Jorjeous <[email protected]>
Co-authored-by: Jorjeous <[email protected]>
Signed-off-by: NeMo Bot <[email protected]>
nithinraok pushed a commit that referenced this pull request Nov 21, 2025
* update run_server to run



* Apply isort and black reformatting



---------

Signed-off-by: George Zelenfroind <[email protected]>
Signed-off-by: Jorjeous <[email protected]>
Signed-off-by: NeMo Bot <[email protected]>
Co-authored-by: George <[email protected]>
Co-authored-by: Jorjeous <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ASR r2.6.0 Cherry-pick label for the r2.6.0 release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants