Skip to content

Conversation

@galagam
Copy link
Contributor

@galagam galagam commented Nov 12, 2025

Blocking was added as a WAR for TensorRT bug 5336870, fixed in TensorRT 10.14

What does this PR do?

Type of change: Bug fix

Overview: Unblock LSTM from conversion to 16-bit in AutoCast. Blocking was added as a WAR for TensorRT bug 5336870 (TRT only supported FP32 LSTM). Bug was fixed in TensorRT 10.14 which is now released.

Usage

# Add a code snippet demonstrating how to use this

Testing

Before your PR is "Ready for review"

  • Make sure you read and follow Contributor guidelines and your commits are signed.
  • Is this change backward compatible?: Yes
  • Did you write any new necessary tests?: No
  • Did you add or update any necessary documentation?: No
  • Did you update Changelog?: No

Additional Information

Blocking was added as a WAR for TensorRT bug 5336870, fixed in TensorRT 10.14

Signed-off-by: Gal Hubara Agam <[email protected]>
@galagam galagam self-assigned this Nov 12, 2025
@galagam galagam requested a review from a team as a code owner November 12, 2025 08:49
@galagam galagam requested a review from i-riyad November 12, 2025 08:49
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.37%. Comparing base (7d0f7a9) to head (71085a1).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #544   +/-   ##
=======================================
  Coverage   74.37%   74.37%           
=======================================
  Files         182      182           
  Lines       18219    18219           
=======================================
  Hits        13550    13550           
  Misses       4669     4669           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@galagam galagam merged commit e3e399a into main Nov 16, 2025
26 checks passed
@galagam galagam deleted the dev-gagam-lstm-unblock branch November 16, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants