Improvements to dockerfile #111
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to deploy FoundationStereo as a docker container and found problems with the current dockerfile:
This PR updates the dockerfile to address those problems.
/FoundationStereorun_demo.py, but that would require that the docker build machine have a GPU, and would require disabling docker buildkit. So I wrote a script, download_weights.py, that doesn't require a CPU. Now someone can build the docker image and run this model without any internet connection.Please note that I made a copy of the model weights to my huggingface account. I didn't want to do this, but the current weights are on Google Drive and using gdown can result in throttling and thus build failures. After that kept happening to me, I decided to use huggingface. I recommend putting the weights onto HF with an nvidia account.
I think it would be great if you published this image. You could publish versions with various model weights. This can be done with github actions and I'd be happy to help with that as I have experience with that. Then someone could simply pull the image down and start using it.
Regarding
run_container.sh, Bowen this is clearly for your dev purposes, as your name is in it lol. If you want to run this container for development, you can use docker compose or modify that script to be a little more generic. I can help with that too.Thanks, great work on this model. I hope this PR helps address the deployment side a bit for those looking to test it out