feat: make object key types always extend string #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Patrik Hellberg Ramel <[email protected]>
mrnagydavid
reviewed
Oct 15, 2025
kirillgroshkov
approved these changes
Oct 15, 2025
Member
kirillgroshkov
left a comment
kirillgroshkov
left a comment
There was a problem hiding this comment.
LGTM.
But David's feedback is to be respected too. He knows more about unit tests than me. I checked.
Collaborator
|
Most of my comments were addressed 🙏 Since the PR touched the typings there, I think a type-unit-test would be nice there too. |
Contributor
Author
|
Oh, sorry 🙏 |
frodi-karlsson
force-pushed
the
better-object-keys
branch
from
8749e34 to
86f4a0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I understand the test may be useless 😅 If the types are reverted, it will fail at tsc with a type error though