update target_max_lum_nits from LedSettingsBaseModel itself #103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Control target_max_lum_nits from LedSettingsBaseModel itself
Summary
For OpenVPCal application, this is duplicated process because
LedWallSettings's@propertysetter has a logic to handle this.However, the colour calibration plugin use
LedSettingsBaseModelinstead ofLedWallSettingsto manage data, it'd be very handy to have thismodel_validatorsotarget_max_lum_nitscan get updated based ontarget_eotf.I understand this can be controversial, so I'll back out it this is not desired change.