Bugfix: Propagate Spring request context to virtual thread pool #2225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
first
Pull Request type
Changes in this PR
Setting
dgs.graphql.virtualthreads.enabled=truebreaks Spring request context propagation because the configuredAsyncTaskExecutoruses virtual threads which don't inherit theRequestAttributesstored in thread local.The consequence is for example that DGS handler methods can't access request scoped beans which are required for many use cases like DB table auditing.
We can propagate the request context to virtual threads by using a custom
ThreadLocalAccessorwhich restores the thread local when the virtual threads switch context.Alternatives considered
We currently provide our own
AsyncTaskExecutor. However, propagating the Spring request context should be included in the default configuration since the framework already has the dependency on Spring Web and core featured don't work without it.