Skip to content

Make some fields final where possible #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kilink wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make some fields final where possible #763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hollow/src/main/java/com/netflix/hollow/api/client/HollowUpdatePlan.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
*/
public class HollowUpdatePlan implements Iterable<HollowConsumer.Blob> {

public static HollowUpdatePlan DO_NOTHING = new HollowUpdatePlan(Collections.emptyList());
public static final HollowUpdatePlan DO_NOTHING = new HollowUpdatePlan(Collections.emptyList());

private final List<HollowConsumer.Blob> transitions;

Expand All @@ -39,7 +39,7 @@ private HollowUpdatePlan(List<HollowConsumer.Blob> transitions) {
}

public HollowUpdatePlan() {
this.transitions = new ArrayList();
this.transitions = new ArrayList<>();
}

public boolean isSnapshotPlan() {
Expand Down
4 changes: 2 additions & 2 deletions hollow/src/main/java/com/netflix/hollow/core/index/HollowSparseIntegerSet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ public class HollowSparseIntegerSet implements HollowTypeStateListener {

protected volatile SparseBitSet sparseBitSetVolatile;

private Set<Integer> valuesToSet;
private Set<Integer> valuesToClear;
private final Set<Integer> valuesToSet;
private final Set<Integer> valuesToClear;
private int maxValueToSet;

public interface IndexPredicate {
Expand Down
2 changes: 1 addition & 1 deletion ...n/java/com/netflix/hollow/core/memory/encoding/GapEncodedVariableLengthIntegerReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@

public class GapEncodedVariableLengthIntegerReader {

public static GapEncodedVariableLengthIntegerReader EMPTY_READER = new GapEncodedVariableLengthIntegerReader(null, 0) {
public static final GapEncodedVariableLengthIntegerReader EMPTY_READER = new GapEncodedVariableLengthIntegerReader(null, 0) {
@Override
public int nextElement() {
return Integer.MAX_VALUE;
Expand Down
4 changes: 2 additions & 2 deletions hollow/src/main/java/com/netflix/hollow/core/memory/pool/WastefulRecycler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
*/
public class WastefulRecycler implements ArraySegmentRecycler {

public static WastefulRecycler DEFAULT_INSTANCE = new WastefulRecycler(11, 8);
public static WastefulRecycler SMALL_ARRAY_RECYCLER = new WastefulRecycler(5, 2);
public static final WastefulRecycler DEFAULT_INSTANCE = new WastefulRecycler(11, 8);
public static final WastefulRecycler SMALL_ARRAY_RECYCLER = new WastefulRecycler(5, 2);

private final int log2OfByteSegmentSize;
private final int log2OfLongSegmentSize;
Expand Down
2 changes: 1 addition & 1 deletion hollow/src/main/java/com/netflix/hollow/tools/combine/IdentityOrdinalRemapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
*/
public class IdentityOrdinalRemapper implements OrdinalRemapper {

public static IdentityOrdinalRemapper INSTANCE = new IdentityOrdinalRemapper();
public static final IdentityOrdinalRemapper INSTANCE = new IdentityOrdinalRemapper();

private IdentityOrdinalRemapper() { }

Expand Down