Thiagodeev/fix-fee-limit #819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified the FeeEstToResBoundsMap function to include an optional parameter for custom limits on resource bounds. - Updated all relevant calls to FeeEstToResBoundsMap across transaction building functions and tests to accommodate the new parameter. - Enhanced error handling for gas price and amount limits to ensure proper validation and defaulting behavior.
- Added new test cases to TestFeeEstToResBoundsMap to validate behavior with fee limits and multipliers. - Adjusted expected values to reflect accurate calculations based on the new fee limit logic.
thiagodeev
changed the base branch from
thiagodeev/feat-tip-estimation
to
main
thiagodeev
commented
Oct 31, 2025
rodrigo-pino
reviewed
Nov 2, 2025
- New test case for only one limit value provided, assuring no overflow above the u64 and u128 limits
rodrigo-pino
previously approved these changes
Nov 3, 2025
Contributor
rodrigo-pino
left a comment
rodrigo-pino
left a comment
There was a problem hiding this comment.
Very good refactor. Some small comments
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in [Nubia] Starknet.go
Collaborator
Author
|
Thanks to @tarrencev for the report! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the bug in the
utils.FeeEstToResBoundsMapfunction, which was using the max uint64 value for the L2 gas amount limit instead of the limit defined by Starknet, causing the txn to be rejected by the node when the amount was greater than the limit. Now, the limit is used correctly, and it's returned in the case of overflow.It also adds a new feature to specify custom limits for the resource bounds.
utils.CustomFeeEstToResBoundsMapfunction that does the same asutils.FeeEstToResBoundsMap, but accepts autils.FeeLimitsparameter to set custom limits for the resource bounds instead of using the Starknet default limits.U128.ToBigInt()method to improve the type usage and validation