Skip to content

Conversation

@murjune
Copy link
Member

@murjune murjune commented Feb 16, 2025

1.1.0v 에 추가/변경된 icon Asset 추가했습니다~

  • 기존 DobeDobeCheckBox 의 icon이 Checked/UnChecked -> FlagFilled/FlagOutLined 로 바뀌었습니다.
  • CheckBox에서 checked/unChecked iconRes 를 받을 수 있도록 열어둘까 고민을 하고 있는데, 어떠신가요?
@Composable
fun DobeDobeCheckBox(
    checked: Boolean,
    @DrawableRes unCheckedIconRes: Int = DobeDobeIcons.FlagFilled,
    @DrawableRes checkedIconRes: Int = DobeDobeIcons.FlagOutLined,
   ...
)

@murjune murjune self-assigned this Feb 16, 2025
@murjune murjune marked this pull request as ready for review February 16, 2025 09:47
Copy link
Member

@nohjunh nohjunh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네네, 열어주셔도 될 것 같아요~

@murjune
Copy link
Member Author

murjune commented Feb 16, 2025

추가로, 기존 checked, unchecked icon 도 새로운 Icon으로 변경했습니다~ 8637826

이 과정에서 24dp --> 36dp 로 바뀌면서 Icon이 짤려, CheckBox size를 44dp 로 설정했습니다

@murjune murjune merged commit 023276f into develop Feb 16, 2025
1 check passed
@murjune murjune deleted the chore/add-new-icon branch February 16, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants