extract reference documentation on remote builds #9526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 2, 2023
Merged
fricklerhandwerk
force-pushed
the
builder-reference-doc
branch
2 times, most recently
from
acee315 to
8ffd5de
Compare
Janik-Haag
reviewed
Dec 2, 2023
Member
Janik-Haag
left a comment
Janik-Haag
left a comment
There was a problem hiding this comment.
Is there a way of rendering these changes locally, reading the diff github produces is a bit hard, I would gladly help reviewing this.
Contributor
Author
|
No, unfortunately still, you have to go through the whole build process locally to produce a rendering. Run |
fricklerhandwerk
force-pushed
the
builder-reference-doc
branch
from
8ffd5de to
3b7c593
Compare
edolstra
reviewed
Dec 5, 2023
fricklerhandwerk
commented
Dec 6, 2023
fricklerhandwerk
commented
Dec 6, 2023
- move all reference documentation to the `builders` configuration setting - reword documentation on machine specification, add examples - disable showing the default value, as it rendered as `@/dummy/machines`, which is wrong - highlight the examples - link to the configuration docs for distributed builds - builder -> build machine
fricklerhandwerk
force-pushed
the
builder-reference-doc
branch
from
e36f6eb to
ed3a26c
Compare
Contributor
Author
|
The speed factor changed from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#9202 (comment)
Context
This is a large diff, but in essence it does this:
buildersconfiguration setting@/dummy/machines, which is wrongThis work is sponsored by Antithesis ✨
Priorities
Add 👍 to pull requests you find important.