expectBytes: mismatches on Http.Request' errorType are ... awkward
#140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ExpectBytesResponse` and `ExpectTextResponse` can have different error types in their `HttpRequest' e a` Printing the full type helps us consider that when inspecting our mocks
Debug.todo is firing here. It shouldn't, but I don't see a way to fix it, since `ExpectText` and `ExpectBytesResponse` can both pack anything as their error type.
omnibs
changed the title
expectBytes: error type mismatch is ... awkwardexpectBytes: mismatches on Http.Request' errorType are ... awkward
| handleCustomResponse f = case f (Internal.NetworkError_ msg) of | ||
| Err err -> Task.fail err | ||
| Ok _ -> Debug.todo "Since we manually craft the Response as an Error, this case will not run." | ||
| Ok _ -> Debug.todo msg |
Contributor
There was a problem hiding this comment.
Developer: "This thing will not happen"...
Real world: Thing happens
😅
Member
Author
There was a problem hiding this comment.
what's super weird is this was not happening on your branch in the monorepo
you were getting a message saying "no stub for GoogleWhatevsResponse" instead of hitting the Debug.todo
here in haskell-libraries i was hitting the Debug.todo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit message comments)