-
Couldn't load subscription status.
- Fork 2
add cases used in the pyperf repo #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request adds new test cases to the pyperf benchmark suite. It includes test cases for libraries such as html5lib, Mako, Tornado, SQLAlchemy, Genshi, Chameleon, Dulwich, and SymPy. Each test case has a corresponding .py file with the implementation and a .yml file with the case configuration. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @KRRT7 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a README file to the cases directory explaining the purpose and structure of the test cases.
- It would be good to have a consistent naming scheme for the test case files (e.g.,
PackageNameUsing.py).
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
currently have added 8, will add the rest next weekend
Summary by Sourcery
Add test cases for the following packages: html5lib, mako, tornado, sqlalchemy, genshi, chameleon, and dulwich.
New Features: