Skip to content

Conversation

@KRRT7
Copy link
Contributor

@KRRT7 KRRT7 commented Mar 3, 2025

currently have added 8, will add the rest next weekend

Summary by Sourcery

Add test cases for the following packages: html5lib, mako, tornado, sqlalchemy, genshi, chameleon, and dulwich.

New Features:

  • Add a test case for html5lib.
  • Add a test case for mako.
  • Add a test case for tornado.
  • Add test cases for sqlalchemy.
  • Add a test case for genshi.
  • Add a test case for chameleon.
  • Add a test case for dulwich.

@sourcery-ai
Copy link

sourcery-ai bot commented Mar 3, 2025

Reviewer's Guide by Sourcery

This pull request adds new test cases to the pyperf benchmark suite. It includes test cases for libraries such as html5lib, Mako, Tornado, SQLAlchemy, Genshi, Chameleon, Dulwich, and SymPy. Each test case has a corresponding .py file with the implementation and a .yml file with the case configuration.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added several new test cases for popular Python libraries to the benchmark suite.
  • Added a test case for html5lib.
  • Added a test case for Mako templating engine.
  • Added a test case for Tornado web framework.
  • Added two test cases for SQLAlchemy (Declarative and Imperative styles).
  • Added a test case for Genshi templating engine.
  • Added a test case for Chameleon templating engine.
  • Added a test case for Dulwich (Git library).
  • Added a test case for SymPy (symbolic mathematics library).
cases/htmlib5/data/w3_tr_html5.html
cases/mako/MakoUsing.py
cases/tornado/TornadoUsing.py
cases/sqlaqlchemy/SqlAlchemyDeclarativeUsing.py
cases/sqlaqlchemy/SqlachemyImperativeUsing.py
cases/sqlaqlchemy/case.yml
cases/genshi/GenshiUsing.py
cases/chameleon/case.yml
cases/dulwichlog/case.yml
cases/genshi/case.yml
cases/htmlib5/case.yml
cases/mako/case.yml
cases/sympy/case.yml
cases/tornado/case.yml
cases/chameleon/ChameleonUsing.py
cases/dulwichlog/DulwichUsing.py
cases/dulwichlog/data/asyncio.git/COMMIT_EDITMSG
cases/dulwichlog/data/asyncio.git/FETCH_HEAD
cases/dulwichlog/data/asyncio.git/HEAD
cases/dulwichlog/data/asyncio.git/ORIG_HEAD
cases/dulwichlog/data/asyncio.git/config
cases/dulwichlog/data/asyncio.git/description
cases/dulwichlog/data/asyncio.git/hooks/applypatch-msg.sample
cases/dulwichlog/data/asyncio.git/hooks/commit-msg.sample
cases/dulwichlog/data/asyncio.git/hooks/post-update.sample
cases/dulwichlog/data/asyncio.git/hooks/pre-applypatch.sample
cases/dulwichlog/data/asyncio.git/hooks/pre-commit.sample
cases/dulwichlog/data/asyncio.git/hooks/pre-push.sample
cases/dulwichlog/data/asyncio.git/hooks/pre-rebase.sample
cases/dulwichlog/data/asyncio.git/hooks/prepare-commit-msg.sample
cases/dulwichlog/data/asyncio.git/hooks/update.sample
cases/dulwichlog/data/asyncio.git/info/exclude
cases/dulwichlog/data/asyncio.git/info/refs
cases/dulwichlog/data/asyncio.git/logs/HEAD
cases/dulwichlog/data/asyncio.git/logs/refs/heads/master
cases/dulwichlog/data/asyncio.git/logs/refs/remotes/origin/master
cases/dulwichlog/data/asyncio.git/objects/info/packs
cases/dulwichlog/data/asyncio.git/packed-refs
cases/dulwichlog/data/asyncio.git/refs/remotes/origin/HEAD

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @KRRT7 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a README file to the cases directory explaining the purpose and structure of the test cases.
  • It would be good to have a consistent naming scheme for the test case files (e.g., PackageNameUsing.py).
Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟡 Complexity: 1 issue found
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant