-
Notifications
You must be signed in to change notification settings - Fork 162
Asyncio support #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Asyncio support #100
Conversation
|
Is this a breaking change or is this compatible with all older code too? |
This breaks the original searching function. |
|
Progress: Now added compatibility to sync search function. |
|
Sorry for the late response! Would you mind putting it in a separate file just to make the code a little cleaner? |
I'd like to but the main structure was set in the init file. It should be a separate file itself so I can make a symmetric one. |
|
Sorry about the long delay! Couldn't you add |
|
Optimized as requested. |
|
Update: now we recover from the Lynx drop. |
|
can I just update the UA to make the search function working without changing to async method? |
Sure you can, and this branch supports the original sync method too. |
|
This UA also doesn't work now, I think implementing something like a headless browser (#117) is the best strategy |
Quite a rough one, using httpx instead of requests.
Comes together with a simple example.