Added fallbacks for finding description and title #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nv7-GitHub
requested changes
May 24, 2024
Owner
Nv7-GitHub
left a comment
Nv7-GitHub
left a comment
There was a problem hiding this comment.
It overall looks good, I will try to pull it and test it in a couple of weeks!
| result_block = soup.find_all("div", attrs={"class": "g"}) | ||
| if len(result_block) ==0: | ||
| if len(result_block) == 0: | ||
| print("Result block empty") |
Owner
There was a problem hiding this comment.
Probably shouldn't have a print here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that a lot of my searches were returning no results because search() couldn't locate the description, so I made some changes that allow it to return a result as long as the link is found. If the description is not found using -webkit-line-clamp: 2, then it looks for a within the result that has as an immediate child. If this is also unsuccessful, it simply returns a concatenation of all of the visible text within the result. This isn't a perfect solution for human readability, but it's still helpful to AI agents that will make use of this package.