[UPD] adapt to new cronjobs, simplify branch initialization#5394
[UPD] adapt to new cronjobs, simplify branch initialization#5394hbrunn wants to merge 1 commit intoOCA:documentationfrom
Conversation
| # Replace No-Dot Syntax (140, 150, ...) | ||
| sed -i "s/$NODOTDOLD/$NODOTNEW/g" .github/workflows/* | ||
| sed -i "s/$NODOTPREV/$NODOTDOLD/g" .github/workflows/* | ||
| sed -i "s/$NODOTDOLD/$NODOTNEW/g" .github/workflows/{documentation-commit.yml,test-migration.yml} |
There was a problem hiding this comment.
test-migration.yml does not exist in the repository, so it raises an error (or is a problem with my environment)
There was a problem hiding this comment.
did you do the renaming with the commandline as pointed out above?
There was a problem hiding this comment.
@sergiocorato need any help here? Note this won't work any more now that #5395 is merged, to test this now you'll need to rewind the 19.0 branch on your fork to before this merge, change the remote in the script to use your fork and still add the line from above after line 7
There was a problem hiding this comment.
@sergiocorato need any help here? Note this won't work any more now that #5395 is merged, to test this now you'll need to rewind the 19.0 branch on your fork to before this merge, change the remote in the script to use your fork and still add the line from above after line 7
I feel very sorry for the big delay, I changed my notification setup to try to do not miss anymore replies.
I used the branch of this PR to do the test and misunderstood the required change.
Now following the suggested tips I managed to do it, thanks!
There was a problem hiding this comment.
I made a test as suggested, for what it could be useful I pushed the branch with the resulting changes: https://github.com/efatto/OpenUpgrade/tree/19.0-initialize
I approve as it works, maybe I'm unable to see if there is something missing.
as I propose to make OpenUpgrade behave more like a standard OCA repo, here the changes coming with this, and also I propose to rely on the cronjobs for unpleasant work.
Note that the script won't run for 18.0 because I renamed the test.yml file, if you want to test the script, add
FILTER_BRANCH_SQUELCH_WARNING=1 git filter-branch --tree-filter '[ -f .github/workflows/test.yml ] && mv .github/workflows/test.yml .github/workflows/test-migration.yml || true' 18.0after line 7, that's what I did