[OU_ADD] website_sale_product_description: rename field#5409
[OU_ADD] website_sale_product_description: rename field#5409luisDIXMIT wants to merge 1 commit intoOCA:18.0from
Conversation
luisDIXMIT
force-pushed
the
18.0-ou_add-website-sale_product_description
branch
2 times, most recently
from
345d33c to
35686ba
Compare
| openupgrade.logged_query( | ||
| env.cr, "UPDATE product_ribbon SET text_color='' WHERE text_color IS NULL" | ||
| ) | ||
| openupgrade.logged_query( |
There was a problem hiding this comment.
No, you should add here a check if the field public_description exists. Imagine that the module is not installed 😉
There was a problem hiding this comment.
Thanks, is correct now?
luisDIXMIT
force-pushed
the
18.0-ou_add-website-sale_product_description
branch
from
35686ba to
91f69f9
Compare
| env.cr, "UPDATE product_ribbon SET text_color='' WHERE text_color IS NULL" | ||
| ) | ||
| if openupgrade.column_exists(env.cr, "product_template", "public_description"): | ||
| openupgrade.logged_query( |
There was a problem hiding this comment.
Add a comment to know why it is here, but yes, this is how it should be.
…escription to description_ecommerce
luisDIXMIT
force-pushed
the
18.0-ou_add-website-sale_product_description
branch
from
91f69f9 to
03edb15
Compare
hbrunn
left a comment
hbrunn
left a comment
There was a problem hiding this comment.
product.template#description_ecommerce existed in v17 already, so I don't think it should be overwritten unconditionally
|
Probably that means that the migration script should be in 17, isn't it? |
|
but the module that's merged in providing the field has been migrated to v17. probably that shouldn't have happened? |
|
Probably... At least in my opinion, that need can be filled with the field provided by odoo 🤔 |
4 participants
Merged module website_sale_product_description into website_sale.
Renamed field public_description to description_ecommerce.