[FIX][16.0] commissions: Tweak commission permissions#659
Open
[FIX][16.0] commissions: Tweak commission permissions#659
Conversation
Contributor
|
Hi @pedrobaeza, |
…ommission_manager
b26fa6d to
663fc0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR involves several modules in order to have a consistent state across all commission modules.
The goal is to clarify permissions:
Commits involved:
[FIX] sale_commission: Better look on Sale Commission Actions
This commit gives a better look to this group and buttons
[FIX] sale_commission: Commission Users can edit agent lines
This Commit is related to allow only to Commission Users the possibility to change or add new Agents to commissions
[FIX] account_commission: Action buttons available for Invoicing permissions
Actions on settlements are available for invocing users only (Commission Invoicing and Account Invoicing).
[FIX] commission: Cancel settlement button only available for group_commission_manager
Cancel button is visible for Commission Users, but clicking it throws an error.
MT-12373 @moduon @pedrobaeza @rafaelbn @yajo please review if you want 😄