Skip to content

[16.0][FIX] rma: add access read to stock user#466

Open
sbejaoui wants to merge 1 commit intoOCA:16.0from
acsone:16.0-rma_access-sbj
Open

[16.0][FIX] rma: add access read to stock user#466
sbejaoui wants to merge 1 commit intoOCA:16.0from
acsone:16.0-rma_access-sbj

Conversation

@sbejaoui
Copy link
Contributor

@sbejaoui sbejaoui commented Aug 4, 2025 •
edited
Loading

The rma_receiver_ids field is is in the list of fields for moves merge, which requires read access to the rma model.
This PR adds read access to stock users, preventing access errors during move merging

@sbejaoui
[FIX] rma: add access read to stock user
30e93be 
The rma_receiver_ids field is is in the list of fields for moves merge, which
requires read access to the rma model.
This commit adds read access to stock users, preventing access errors during move merging
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Aug 4, 2025

Hi @pedrobaeza, @chienandalu,
some modules you are maintaining are being modified, check this out!

@sbejaoui sbejaoui changed the title [FIX] rma: add access read to stock user [16.0][FIX] rma: add access read to stock user Aug 4, 2025
@pedrobaeza pedrobaeza added this to the 16.0 milestone Aug 4, 2025
pedrobaeza
pedrobaeza reviewed Aug 4, 2025
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit reluctant of using this solution, as it gives too much access to stock users. Can we find another solution for the merge problem?

phschmidt
phschmidt approved these changes Sep 16, 2025
View reviewed changes
Copy link

@phschmidt phschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally tested

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Sep 16, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@github-actions
Copy link

github-actions bot commented Jan 18, 2026

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrobaeza pedrobaeza pedrobaeza left review comments

+2 more reviewers

@chienandalu chienandalu chienandalu approved these changes

@phschmidt phschmidt phschmidt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Milestone

16.0

Development

Successfully merging this pull request may close these issues.

5 participants

@sbejaoui @OCA-git-bot @chienandalu @pedrobaeza @phschmidt