Skip to content

[19.0][IMP] upgrade_analysis: avoid "empty" analysis files #3493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OCA-git-bot merged 1 commit into from
Jan 16, 2026
Merged

[19.0][IMP] upgrade_analysis: avoid "empty" analysis files #3493

OCA-git-bot merged 1 commit into from
Jan 16, 2026
+27 −22

Conversation

@MiquelRForgeFlow
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow commented Jan 15, 2026 •
edited
Loading

Before this patch, sometimes analysis files were created for the modules doesnt' contain any "change". Let's avoid that.

Besides other minor fixes, this patch improves the coverage file: No more "No DB layout changes" message on modules that contain the noupdate_changes.xml file.

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jan 15, 2026

Hi @legalsylvain, @StefanRijnhart,
some modules you are maintaining are being modified, check this out!

@pedrobaeza pedrobaeza added this to the 19.0 milestone Jan 15, 2026
@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 19.0-imp-upgrade_analysis branch from 94b6df9 to dc8fa24 Compare January 15, 2026 15:44
@MiquelRForgeFlow MiquelRForgeFlow changed the title [19.0][IMP] upgrade_analysis: create migration folder for all modules [19.0][IMP] upgrade_analysis: avoid "empty" analysis files Jan 15, 2026
@MiquelRForgeFlow
Copy link
Contributor Author

MiquelRForgeFlow commented Jan 15, 2026

cc: @hbrunn

pedrobaeza
pedrobaeza approved these changes Jan 15, 2026
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

hbrunn
hbrunn requested changes Jan 16, 2026
View reviewed changes
Copy link
Member

@hbrunn hbrunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a branch with the output of this changes for comparison?

BTW please merge OCA/OpenUpgrade#5389 so that we can conveniently generate a baseline

@MiquelRForgeFlow
[IMP] upgrade_analysis: avoid "empty" analysis files
aca06d6 
Before this patch, sometimes analysis files were created for the modules doesnt' contain any "change". Let's avoid that.

Besides other minor fixes, this patch improves the coverage file: No more "No DB layout changes" message on modules that contain the `noupdate_changes.xml` file.
@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 19.0-imp-upgrade_analysis branch from dc8fa24 to aca06d6 Compare January 16, 2026 11:07
@MiquelRForgeFlow
Copy link
Contributor Author

MiquelRForgeFlow commented Jan 16, 2026

do we have a branch with the output of this changes for comparison?

No..., but nothing should break. We should expect less modules folders (I mean, less "empty" analysis files) and less "No DB layout changes" in the coverage file.

@pedrobaeza
Copy link
Member

pedrobaeza commented Jan 16, 2026

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jan 16, 2026

On my way to merge this fine PR!
Prepared branch 19.0-ocabot-merge-pr-3493-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 259e9eb into OCA:19.0 Jan 16, 2026
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jan 16, 2026

Congratulations, your PR was merged at 558ac71. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 19.0-imp-upgrade_analysis branch January 16, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hbrunn hbrunn hbrunn approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees

No one assigned

Labels

approved merged 🎉

Projects

None yet

Milestone

19.0

Development

Successfully merging this pull request may close these issues.

4 participants

@MiquelRForgeFlow @OCA-git-bot @pedrobaeza @hbrunn