-
-
Notifications
You must be signed in to change notification settings - Fork 2k
[18.0][MIG] web_m2x_options_manager: Migration to 18.0 #2975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
chaule97
commented
Oct 29, 2024
- Depends on: [18.0][MIG] web_m2x_options #2961
1475405 to
843bbd8
Compare
|
@chaule97 the dependency is already merged and test-requirements gives and error because the pr is closed, Can you remove that file ? |
…ons from interface
- Fix postprocess inherit (removed from v15), and use _postprocess_tag_field for create/edit options: In v14 it worked with inheriting the "postprocess" method because in each recursive call it passed a section of the view, in the way that it went through all the child nodes of the root node, and passed through the fields, and now in v15 the method "_postprocess_view "it just does the while, and we never go through the nodes. - Fix pylint errors: xml-deprecated-tree-attributte, attribute-string-redundant, translation-positional-used
843bbd8 to
1cada9d
Compare
I updated, could you review my PR? |
|
@chaule97 I'm going to do some tests to see if the module works well, and I'll give you the approve |
clementmbr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Is it possible to merge the PR?
Reyes4711-S73
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@OCA/web-maintainers Please, can you merge this PR? |