Skip to content

Conversation

@AungKoKoLin1997
Copy link
Contributor

@qrtl QT5088

Copy link

@kanda999 kanda999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR didn't work well on runboard.

@AungKoKoLin1997
Copy link
Contributor Author

This PR didn't work well on runboard.

@kanda999 It was really strange and I tested in my local env.
It is working fine. So, I try to uninstall and install again this module in runboat.
After that, I found it is working well. Please check again.

Copy link

@kanda999 kanda999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review: it works as expected.

Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and functional test. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants