Fixes #3387: Decode base64 string safely to call FromBase64String #3395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/AzurePipelines run |
Member
WanjohiSammy
left a comment
WanjohiSammy
left a comment
There was a problem hiding this comment.
Could you add some tests to ensure test coverage
habbes
requested changes
Oct 28, 2025
Contributor
There was a problem hiding this comment.
Let's not use string.Replace. Base64 strings can be arbitrarily large. In this case we're scanning the entire string twice, and also allocating twice. Bad for CPU and memory. Also, everyone will be paying this cost, even scenarios which are not affected by this issue.
| try | ||
| { | ||
| targetValue = Convert.FromBase64String(text); | ||
| targetValue = Convert.FromBase64String(text.Replace('-', '+').Replace('_', '/')); |
Member
There was a problem hiding this comment.
We can move the logic to JsonSharedUtils as it can be used in OData.Core and OData.Client
Contributor
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes #xxx.
Description
Briefly describe the changes of this pull request.
Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.
Repository notes
Team members can start a CI build by adding a comment with the text
/AzurePipelines runto a PR. A bot may respond indicating that there is no pipeline associated with the pull request. This can be ignored if the build is triggered.Team members should not trigger a build this way for pull requests coming from forked repositories. They should instead trigger the build manually by setting the "branch" to
refs/pull/{prId}/mergewhere{prId}is the ID of the PR.