Conversation
| REQUIRE_CONVERSATION_RESOLUTION="{{ require_conversation_resolution | lower }}" | ||
| ./copier_scripts/run_tasks.sh | ||
|
|
||
| #./copier_scripts/run_tasks.sh |
There was a problem hiding this comment.
is there a need for this commented line?
| help: "Not prompted. This is computed for re-use." | ||
| default: "{{ repository_visibility == 'public' }}" | ||
| when: false | ||
| default: false |
There was a problem hiding this comment.
Am I reading this incorrect? It seems to say is_public_repo is false on default if repository_visibility is public?
There was a problem hiding this comment.
So that means :
If the user sets repository_visibility to "public", then is_public_repo will be available (and its value will be false unless overridden)
so this boolian variable will only be available if the user sets the repo to public otherwise by default it will be set to false :)
There was a problem hiding this comment.
this might be causing issues with PIRR.md / codeql.yml
| # Policy Compliance Checklist | ||
|
|
||
| This document verifies compliance with ONS policies for the ${{ values.repository_name }} project. | ||
| This document verifies compliance with ONS policies for the ${{ repository_name }} project. |
There was a problem hiding this comment.
I believe the $ signs are not necessary in jinja... in the generated repo this displays as 'This document verifies compliance with ONS policies for the $test-repo project.' unfortunately it looks like there are a lot of $ signs, not sure if it's worth removing them
| [](https://github.com/${{ repository_owner }}/${{ repository_name }}/actions/workflows/ci.yml) | ||
| [](https://github.com/${{ repository_owner }}/${{ repository_name }}/actions/workflows/security-scan.yml) | ||
| {%- if is_public_repo %} | ||
| [](https://github.com/${{ repository_owner }}/${{ repository_name }}/actions/workflows/codeql.yml) |
There was a problem hiding this comment.
again the $ signs show up in the resulting url
There was a problem hiding this comment.
for some reason the PIRR.md is still generated when the repo is set to Public
There was a problem hiding this comment.
It looks like codeql.yml isn't being generated when the repo is set to Public
3 participants
What is the context of this PR?
Changed '.njk' files to '.jinja' due to copier not rendering all files.
Removed some logic related to njk.
Small changes to devcontainer due to errors when setting up.
small changes to test files due to erros.
How to review
Check if it makes sense and it aligns with the longterm goal of the team.
Follow-up Actions
List any follow-up actions (if applicable), like needed documentation updates or additional testing.