Refactor: Extract updateWellGroupTargets() from updateAndCommunicateGroupData() #6733
+201
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakonhagland
added
the
manual:irrelevant
Contributor
Author
|
jenkins build this please |
hakonhagland
force-pushed
the
refact_ucgd2
branch
3 times, most recently
from
477b9ec to
ab7e8e9
Compare
Contributor
Author
|
jenkins build this please |
hakonhagland
force-pushed
the
refact_ucgd2
branch
from
ab7e8e9 to
f9b120f
Compare
Contributor
Author
|
jenkins build this please |
Add a bitmask-based modification tracking mechanism to GroupState that allows communicate_rates() to selectively communicate only vectors that have been modified since the last communication. This prevents double- counting when communicate_rates() is called multiple times and reduces redundant MPI communication. Changes: - Add Modification enum with flags for each rate vector type - Add mark_modified() calls to all 8 update methods - Update communicate_rates() to only include modified vectors - Clear modification flags after successful communication - Add early exit when no data needs communication
hakonhagland
force-pushed
the
refact_ucgd2
branch
from
f9b120f to
82bb77c
Compare
Contributor
Author
|
jenkins build this please |
…roupData() Separate the well group target calculation into its own method to: 1. Fix semantic mismatch - updateAndCommunicateGroupData() now only updates and communicates group data (VREP, REIN, rates). The well group target calculation is a distinct operation that happens after MPI communication. 2. Eliminate redundant computation in beginTimeStep() - Previously the second call to updateAndCommunicateGroupData() recomputed all group data just to get well group targets. Now it only calls updateWellGroupTargets(). 3. Clarify that well group targets don't need MPI communication - each rank computes targets only for its owned wells using the already-communicated group data.
hakonhagland
force-pushed
the
refact_ucgd2
branch
from
82bb77c to
d8e6ec4
Compare
Contributor
Author
|
jenkins build this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #6740, which should be merged first.
Separate the well group target calculation into its own method to:
Fix semantic mismatch -
updateAndCommunicateGroupData()now only updates and communicates group data. The well group target calculation is a distinct operation that happens after MPI communication.Eliminate redundant computation in
beginTimeStep()- Previously the second call toupdateAndCommunicateGroupData()recomputed all group data just to get well group targets.Clarify that well group targets don't need MPI communication - each rank computes targets only for its owned wells using the already-communicated group data.