MSVC: Improve MSVC support (part 3) #5514
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Edouard Choinière <[email protected]>
Co-authored-by: Edouard Choinière <[email protected]>
Co-authored-by: Edouard Choinière <[email protected]>
Co-authored-by: Rashad Kanavath <[email protected]>
github-actions
bot
added
C
echoix
commented
Apr 6, 2025
|
|
||
| #undef M_PI_4 | ||
| #define M_PI_4 0.78539816339744830962 /* pi/4 */ | ||
| #endif |
Member
Author
There was a problem hiding this comment.
Probably to remove too, if the _USE_MATH_DEFINES 1 approach isn't kept.
Suggested change
| #endif |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #356, named "Msvc support 3"
I rebased/cherry-picked the PR #356 in order to make it reviewable. The last 10 commits of that PR were of interest, but multiple have already been included, so less remains.
I tried to make it such as it highlights what was different in the cases where conflicts existed. This means that not everything from this PR might be worthy of including it. At least it is reviewable, and mergeable.
While rebasing, I had to solve the conflict where I think there had been a bad resolution in #3621, and here it contains what I think the original commit wanted to do. See #356 (comment) and #356 (comment).