-
-
Notifications
You must be signed in to change notification settings - Fork 372
r.latlong: return central pixel values for lat or long #6611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
metzm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Good to hear this is approved. I'm fairly new to GRASS development. Should I squash and force-push, update the commit comment, reference #3274, etc.? Anything else from me to do at this point? |
Just press the friendly green "Squash and merge" button and delete your source branch If you do not see a friendly green "Squash and merge" button below or if it is greyed out, you probably do not have rights to merge and someone else needs to merge. |
|
I do not have that green button. |
|
Then I will merge for you, but you need to delete your source branch yourself. |
|
@mankoff Thanks for contributing! Feel free to leave some feedback whether you were able to find contributing guidelines and if so, whether there was something missing that you would find helpful. |
I thought the contribute docs were fine. I was just confused because I could not merge and usually I do see the green button. I would have cleaned up the commit message if I had done the final merge, but that is not very important. The relevant info is in the message. |
Right, the final merging can only be done by maintainers, but there is unfortunately no way for you to specify the merge commit message (besides explicitly suggesting it in a comment or PR description). The default commit message is by default taken from all the commits in the PR, so it's good to make those commit messages meaningful. |
Attempt to fix issues in #5985