-
-
Notifications
You must be signed in to change notification settings - Fork 288
Implement caching for GraphQL resolvers #2528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rudransh-shrivastava
wants to merge
8
commits into
OWASP:main
Choose a base branch
from
rudransh-shrivastava:feature/graphql-caching
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
fa7fe1a
add cache extension
rudransh-shrivastava 8826228
add tests for cache extension
rudransh-shrivastava 33af60c
cache falsy values; coderabbit suggestions
rudransh-shrivastava c23b60c
fix: nested node caching by implementing path based key generation
rudransh-shrivastava c1cd5b2
use CacheFieldExtension in high-cost fields
rudransh-shrivastava f9a2f4e
fix missing badge_count
rudransh-shrivastava cb4820e
Update code
rudransh-shrivastava 6e2d121
Merge branch 'main' into feature/graphql-caching
rudransh-shrivastava File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| """Strawberry extensions.""" | ||
|
|
||
| import json | ||
| from typing import Any | ||
|
|
||
| from django.conf import settings | ||
| from django.core.cache import cache | ||
| from django.core.serializers.json import DjangoJSONEncoder | ||
| from strawberry.extensions.field_extension import FieldExtension | ||
| from strawberry.types.info import Info | ||
|
|
||
|
|
||
| class CacheFieldExtension(FieldExtension): | ||
| """Cache FieldExtension class.""" | ||
|
|
||
| def __init__(self, cache_timeout: int | None = None, prefix: str | None = None): | ||
| """Initialize the cache extension. | ||
|
|
||
| Args: | ||
| cache_timeout (int | None): The TTL for cache entries in seconds. | ||
| prefix (str | None): A prefix for the cache key. | ||
|
|
||
| """ | ||
| self.cache_timeout = cache_timeout or settings.GRAPHQL_RESOLVER_CACHE_TIME_SECONDS | ||
| self.prefix = prefix or settings.GRAPHQL_RESOLVER_CACHE_PREFIX | ||
|
|
||
| def _convert_path_to_str(self, path: Any) -> str: | ||
| """Convert the Strawberry path linked list to a string.""" | ||
| parts = [] | ||
| current = path | ||
| while current: | ||
| parts.append(str(current.key)) | ||
| current = getattr(current, "prev", None) | ||
| return ".".join(reversed(parts)) | ||
|
|
||
| def generate_key(self, source: Any | None, info: Info, kwargs: dict) -> str: | ||
| """Generate a unique cache key for a field. | ||
|
|
||
| Args: | ||
| source (Any | None): The source/parent object. | ||
| info (Info): The Strawberry execution info. | ||
| kwargs (dict): The resolver's arguments. | ||
|
|
||
| Returns: | ||
| str: The unique cache key. | ||
|
|
||
| """ | ||
| key_kwargs = kwargs.copy() | ||
| if source and (source_id := getattr(source, "id", None)) is not None: | ||
| key_kwargs["__source_id__"] = str(source_id) | ||
|
|
||
| args_str = json.dumps(key_kwargs, sort_keys=True, cls=DjangoJSONEncoder) | ||
|
|
||
| return f"{self.prefix}:{self._convert_path_to_str(info.path)}:{args_str}" | ||
|
|
||
| def resolve(self, next_: Any, source: Any, info: Info, **kwargs: Any) -> Any: | ||
| """Wrap the resolver to provide caching.""" | ||
| return cache.get_or_set( | ||
| self.generate_key(source, info, kwargs), | ||
| lambda: next_(source, info, **kwargs), | ||
| timeout=self.cache_timeout, | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.