Port - Fix retryable gas calculation bug and add ArbOS51 version (#4047) #4066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR solves ArbOS 50 issue with retryable transactions then one or more gas constraints are configured for the new pricer algorithm. Original bug was caused by an incorrect calculation of the cost of updating the gas pool, which led to the failure of the redemption transaction due to the ran out of gas. Includes: Store ArbOs version in L2PricingState Fix for constraints gas pool update cost calculation Add ArbOS version 51 and make it default Configure gas pricing constrains by default in system tests and fix related system tests
Member
|
Closed in favor of #4068 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of NIT-4132
Pulls in OffchainLabs/go-ethereum#586
This PR solves ArbOS 50 issue with retryable transactions then one or more gas constraints are configured for the new pricer algorithm. Original bug was caused by an incorrect calculation of the cost of updating the gas pool, which led to the failure of the redemption transaction due to the ran out of gas.
Includes:
Store ArbOs version in L2PricingState
Fix for constraints gas pool update cost calculation
Add ArbOS version 51 and make it default
Configure gas pricing constrains by default in system tests and fix related system tests