Update npm packages & tooling #475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanib
force-pushed
the
feature/frontend_nov_25
branch
7 times, most recently
from
fcef9c0 to
4bf3b06
Compare
johanib
force-pushed
the
feature/frontend_nov_25
branch
from
4bf3b06 to
7eaa2eb
Compare
MKodde
approved these changes
Nov 19, 2025
Member
MKodde
left a comment
MKodde
left a comment
There was a problem hiding this comment.
I have little comments about the code changes. Awesome to see you upgrade these packages and seeing them actually work well! Chapeau!
Questions after clicking through the /preview pages;
- I could not view the previews in env =
test. So either fix that, or only allow insmoketest. Either one is fine with me. My personal preference would be for them to also be available indev. - Could you drop the popper js dependency? Or is it actually used by Gateway? I could not find it, Nor remember where/when we used it 🤔
- Suggestion: add all available SF types to the WAYG screen and maybe fix missing icons?
johanib
force-pushed
the
feature/package_updates_nov_25
branch
2 times, most recently
from
c603724 to
de1f119
Compare
Prior to this change, on dev, test and smoketest environments, the permissions of var/log and var/cache would reset after every cache:clear command. Without these permissions, the site does not work, resulting in a 500. This change ensures correct ownership on local development.
johanib
force-pushed
the
feature/frontend_nov_25
branch
2 times, most recently
from
652973c to
96d8f24
Compare
Prior to this change, eslint used the `airbnb` config. This is a config for react projects. Stepup-Gateway does not use react, resulting in errors, because eslint required things like jsx packages. This change uses `airbnb-base` and adds the required ts support. --- Resolve Sass compilation warnings by running the migrate tool -- Replaced `eslint-loader` with `eslint-webpack-plugin` as eslint-loader is deprecated, and suggests eslint-webpack-plugin as a replacement.
johanib
force-pushed
the
feature/frontend_nov_25
branch
from
96d8f24 to
f63858c
Compare
Silence the rest, as it originates from bootstrap 5, which we do not have control over. Keep an @import for bootstrap in the application.scss as bootstrap is not compatible with newer sass. Also switch sass-loader to use the modern Dart Sass JavaScript API instead of the legacy one. This resolves Module Warning (from ./node_modules/sass-loader/dist/cjs.js): Deprecation The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0. More info: https://sass-lang.com/d/legacy-js-api
ESlint 9 uses a new flat config. The airbnb config is no longer used. Switched to modern `typescript-eslint` * Remove jest
Prior to this change, the js + css would target modern browsers. This change adds autoprefixer to output css for older browsers and babel for the js. Realistically, ie6 support is not possible. This change ensures the modern features of css and js are kept back as much as possible. As the templates function without javascript, really old browsers should click perform the redirect automatically. Apart from autosubmit, no js is used.
johanib
force-pushed
the
feature/frontend_nov_25
branch
from
f63858c to
dbff33a
Compare
Contributor
Author
I decided to only add it to smoketest because:
I'm pretty sure we don't use it. It's a requirement by bootstrap. I dropped it. |
MKodde
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the npm packages to the latest majors.
It removes jest, as it was unused.
It upgrades bootstrap from 3 > 5.
ESlint is upgraded to version 9.
And others..
Some deliberation took place on legacy browser support.
Currently, gateway uses almost no javascript, except for jquery. Before this change, jquery 3 was already used. Jquery 3 is not supported by old browsers at all. So I do not think, js compatibility should be affected. No new javascript code was added.
As for css, autoprefix was added to ensure old browser fallbacks as needed, in response to the bootstrap 5 upgrade.