My Meter DDSU666 (Implementing a device) #3307
Open
+381
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sn0w3y
suggested changes
Sep 11, 2025
There was a problem hiding this comment.
please apply the prepare-commit.sh script again
|
|
||
| @Override | ||
| protected ModbusProtocol defineModbusProtocol() { | ||
| // TODO implement ModbusProtocol |
There was a problem hiding this comment.
Remove unnecessary Comment
| OpenemsComponent.getModbusSlaveNatureTable(accessMode), | ||
| ElectricityMeter.getModbusSlaveNatureTable(accessMode), | ||
|
|
||
| // Custom channels của DDSu666 |
| @Override | ||
| public ModbusSlaveTable getModbusSlaveTable(AccessMode accessMode) { | ||
| return new ModbusSlaveTable( | ||
| // Các nature tables cơ bản |
Sn0w3y
suggested changes
Sep 12, 2025
There was a problem hiding this comment.
Personally I would name the Package meter.chint and under this Package implement the ddsu666 as there are many more (I am working on the DTSU-666 which is the 3-Phase Version of the DDSU
Well - AI told you wrong :D This is not the Case right now :) |
|
You did not change anything right now since my last Comments - maybe check them first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have worked on the integration of the DDSU666 Meter in OpenEMS.
However, there may still be issues in the mapping of Modbus registers, Channel IDs, and data types (FLOAT32, INT16, etc.).
The goals of this PR are to:
Ensure accurate reading of Voltage, Current, Active Power, Reactive Power, Power Factor, and Energy from the DDSU666.
Verify register addresses against the official DDSU666 datasheet.
Keep the code consistent with the OpenEMS coding style.
Request for Support
I would appreciate if the community could:
Review the DDSU666 mapping code.
Cross-check register addresses and data types with the DDSU666 documentation.
Suggest corrections if any registers or logic are incorrect.
Why This Matters
The DDSU666 is a commonly used energy meter in monitoring systems. Incorrect mapping may lead to:
Inaccurate data readings (e.g., wrong power or energy values).
Incorrect visualizations in ThingsBoard dashboards or rule chains.
Next Steps
I will update this PR based on review feedback.
Once finalized, the code will allow stable and accurate data reading from DDSU666 in OpenEMS.