Skip to content

Conversation

@Jasonlee6789
Copy link
Contributor

This PR replaces attr.fill="{{ fillRef }}" with [attr.fill]="fillRef" in SVG polygon bindings for improved Angular consistency and maintainability. The property binding syntax [attr.fill] is the standard Angular approach for dynamic attribute values, ensuring type safety, better template parsing, and alignment with the rest of the codebase.

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3377      +/-   ##
=============================================
+ Coverage      59.78%   59.86%   +0.08%     
  Complexity       112      112              
=============================================
  Files           2785     2787       +2     
  Lines         120785   121037     +252     
  Branches        9015     9061      +46     
=============================================
+ Hits           72205    72452     +247     
+ Misses         45901    45869      -32     
- Partials        2679     2716      +37     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jasonlee6789 Jasonlee6789 marked this pull request as ready for review October 24, 2025 05:54
@da-Kai da-Kai requested a review from sfeilmeier October 24, 2025 15:36
@da-Kai
Copy link
Contributor

da-Kai commented Oct 24, 2025

@Jasonlee6789 thanks. Looks good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants