Skip to content

Conversation

@annehaley
Copy link
Collaborator

This PR upgrades the version of uvdat-flood-sim we use (from 1.0.1 to 1.0.2) and updates the flood sim task accordingly. This includes two changes:

  1. Add new input initial_conditions_id with options ['001', '002', '003']
  2. Specify output path of multiframe TIFF (rather than only specifying the output folder and assuming the filename)

@annehaley annehaley requested a review from BryonLewis January 27, 2026 19:23
Copy link
Collaborator

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine as long as the run_sim from uvdat_flood_sim takes in the new arguments (which I assume).

Should the ./core/tests/test_analytics.py:test_flood_analysis_chain be updated?
Just to test the new input?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants